cleanup IPConfig2/Http Protocol #1640
Open
+9
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
commented
Apr 19, 2025
| @@ -357,12 +357,6 @@ pub fn run_qemu(arch: UefiArch, opt: &QemuOpt) -> Result<()> { | |||
|
|
|||
| cmd.args(["-device", "virtio-rng-pci"]); | |||
|
|
|||
| if arch == UefiArch::IA32 || arch == UefiArch::X86_64 { | |||
| cmd.args(["-debugcon", "file:./integration-test-debugcon.log"]); | |||
There was a problem hiding this comment.
moved it to the arch specific stuff below, where it fits much better
phip1611
commented
Apr 19, 2025
| @@ -357,12 +357,6 @@ pub fn run_qemu(arch: UefiArch, opt: &QemuOpt) -> Result<()> { | |||
|
|
|||
| cmd.args(["-device", "virtio-rng-pci"]); | |||
|
|
|||
| if arch == UefiArch::IA32 || arch == UefiArch::X86_64 { | |||
| cmd.args(["-debugcon", "file:./integration-test-debugcon.log"]); | |||
There was a problem hiding this comment.
moved it to the arch specific stuff below, where it fits much better
It depends on how OVMF is built: https://github.com/tianocore/edk2/blob/62390a89c5eb477594b74b5e1911d65998a8abe2/OvmfPkg/README#L90 Currently, ovmf-prebuilt uses the |
phip1611
changed the title
kraxel
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #1614 by @kraxel.
.gitignoreChecklist